Skip to content

Make new.cc definitions weak #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 20, 2024
Merged

Make new.cc definitions weak #1233

merged 10 commits into from
Jun 20, 2024

Conversation

mrdomino
Copy link
Collaborator

@mrdomino mrdomino commented Jun 19, 2024 •
edited
Loading 

The STL says that these should be replaceable by user code.

new.cc now defines only a few direct functions (including a free wrapper
that perplexingly is needed since g++ didn’t want to alias "free".) Now,
all of the operators are weak references to those functions.

@mrdomino
Add weak specifiers to new.cc definitions
8b7b6a4 
The STL says that these should be replaceable by user code.
@mrdomino mrdomino changed the title Add weak specifiers to new.cc definitions Make new.cc definitions weak Jun 20, 2024
@mrdomino mrdomino force-pushed the new-weak branch 2 times, most recently from 9773edb to df83fa1 Compare June 20, 2024 05:11
mrdomino added 2 commits June 19, 2024 22:16
@mrdomino
Make allocators weak references
0e413ae 
new.cc now only defines three functions, and really they could all be in
one block of assembly if someone felt like being clever about it. All of
the STL functions are defined as weak references from those functions to
their g++-mangled names. (The clang-mangled names have an extra underbar
prepended, incidentally.)
@mrdomino
Comment
2063a80
@mrdomino mrdomino merged commit f86e6f8 into jart:master Jun 20, 2024
@mrdomino mrdomino deleted the new-weak branch June 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jart jart jart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrdomino @jart