Fix vfprintf and derived functions badly handling +/` flag conflict #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C standard states, for conversion specifications containing the +
flag:
> The result of a signed conversion always begins with a plus or minus
> sign. (It begins with a sign only when a value with a negative sign
> is converted if this flag is not specified.)
- C Standard, 7.23.6.2.6. The fprintf function
...meaning that for all conversion but signed conversions, the flag
does nothing (note that flags which would invoke UB when used on an
unexpected conversion explicitly state so).
However, cosmopolitan currently interprets a + flag as equivalent to a
` flag, where the ` flag stands for quoting a character/string,
meaning a program such as:
#include <stdio.h>
int main()
{
printf("%+c\n", '=');
}
will, under cosmopolitan, print:
'='
instead of:
=
(i.e. the output is quoted as if %`c was used as the conversion
specification)
This patch fixes this by making it so the ` flags and + flags are not
internally considered identical, and adds a test for the change.
jart
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message for details)