Feature/sendmsg #148
Merged
Feature/sendmsg #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple struct containing two in_addr objects)
…32_t (the original type is socklen_t and is not signed). Added implementation of recvmsg
…ng the function to return EINVAL on BSD/MacOS for non-connected sockets
jart
requested changes
Apr 8, 2021
test/libc/sock/sendrecvmsg_test.c
Outdated
| /*-*- mode:c;indent-tabs-mode:nil;c-basic-offset:2;tab-width:8;coding:utf-8 -*-│ | ||
| │vi: set net ft=c ts=2 sts=2 sw=2 fenc=utf-8 :vi│ | ||
| ╞══════════════════════════════════════════════════════════════════════════════╡ | ||
| │ Copyright 2021 │ |
There was a problem hiding this comment.
Hmm I copied the header from the socketpair test tha Allison wrote... I removed her name but I forgot to add your...
changed.
test/libc/sock/sendrecvmsg_test.c
Outdated
| msg.msg_iovlen = 1; | ||
| ASSERT_EQ(hwLen, recvmsg(fd[1], &msg, 0)); | ||
|
|
||
| ASSERT_EQ(0, memcmp(&(((char *)(msg.msg_iov[0].iov_base))[0]), hello, strlen(hello))); |
There was a problem hiding this comment.
Try changing malloc(20) to gc(xcalloc(20)). In that case, you can delete the null check and these two lines can simply be EXPECT_STREQ("helloworld", msg.msg_iov[0].iov_base);. You'll need these too of course:
#include "libc/runtime/gc.internal.h"
#include "libc/x/x.h"
jart
added a commit
that referenced
this pull request
Apr 8, 2021
The send{,to,msg} and recv{,from,msg} functions have been updated to
delegate to WriteFile and ReadFile when appropriate, due to the fact
that socketpair(AF_UNIX) is implemented using kFdFile.
Thanks @fabriziobertocci for writing the test that caught this.
See #148 and #122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation and unit test for sendmsg() and recvmsg().
Tested on Linux, Mac and Windows.