Add imaxdiv, wcscoll, getdtablesize #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izissise
force-pushed
the
compile-bash
branch
from
26719d0 to
601cdf0
Compare
|
Fixed for contributing guidelines |
izissise
force-pushed
the
compile-bash
branch
from
601cdf0 to
20214b7
Compare
jart
requested changes
Oct 2, 2022
libc/calls/getdtablesize.c
Outdated
| */ | ||
| int getdtablesize(void) { | ||
| // glibc says the result on WinXP is 2048 | ||
| return 2048; |
There was a problem hiding this comment.
Cool I didn't know about this function. The right thing to do here with cosmo is return g_fds.n.
There was a problem hiding this comment.
Oh nice, I didn't know about g_fds.n, should be good now.
test/libc/fmt/imaxdiv_test.c
Outdated
| EXPECT_EQ(0, res.quot); | ||
| EXPECT_EQ(0, res.rem); | ||
|
|
||
| res = imaxdiv(INT64_MIN, -1); |
There was a problem hiding this comment.
INTMAX_MAX- Why isn't this raising an arithmetic exception? It should.
int main(int argc, char *argv[]) {
volatile intmax_t i, j;
i = INTMAX_MIN;
j = -1;
i = i / j;
return 0;
}There was a problem hiding this comment.
Scratch that. According to GitHub Actions, it does raise SIGFPE. Good.
There was a problem hiding this comment.
Oops I meant not to overflow, I fixed the test
Just call wcscoll_l with tls locale
G4Vi
pushed a commit
to G4Vi/cosmopolitan
that referenced
this pull request
Jan 27, 2023
jart
pushed a commit
that referenced
this pull request
Jan 30, 2023
Co-authored-by: Hugues Morisset <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some added function implementation that are missing when compiling bash