Fix ParseHttpMessage failing to store >2 repeatable headers #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseHttpMessage had a bug where
HttpMessage.xheaders
would not exceed a capacity of1
inside ofParseHttpMessage
. This resulted in only 2 repeatable headers being stored, the first inHttpMessage.headers
, and the second in the 1-capacityHttpMessage.xheaders
.This pull request implements a unit test to detect this bug and a fix that passes the unit test. Now, when
xheaders
has 0 capacity, it's set to 1, and when it's full, the capacity gets doubled.Also,
clang-format
rearranged the headers in the test file.