Implement __zipos_dup #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdomino
force-pushed
the
zipos-dup
branch
5 times, most recently
from
ed1579c to
7b4a032
Compare
mrdomino
commented
Nov 30, 2023
jart
reviewed
Nov 30, 2023
mrdomino
force-pushed
the
zipos-dup
branch
3 times, most recently
from
90bed99 to
b961f4d
Compare
Makes ZiposHandle reference-counted by an `rc` field in a union with its freelist `next` pointer. The functions `__zipos_free` and `__zipos_keep` function as incref/decref for it. Adds `__zipos_postdup` to fix metadata on file descriptors after dup-like operations, and adds zipos support to `sys_dup_nt` + `sys_close_nt`.
rc is never a zipos file because it is always a previously unused file descriptor. fd is never a zipos file because that case has been handled above by __zipos_fcntl.
jart
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Looks good to me. This is an impressive change. I cloned your branch locally and ran it on my test fleet of VMs (freebsd rhel7 xnu win10 openbsd netbsd pi silicon) using runit and runitd. I was amazed to see it all green.
I've contacted you about the copyright thing. Once that happens, I'll merge this.
|
Sadly the commit message fell out of sync with the actual changes, and I had a couple more changes in flight (implementing atomic reads and seeks even though POSIX says they don't exist because why not). What's the best approach - put the new changes on a new branch or force-push to main? |
|
It's probably too late to force push at this point. I'll make a mental note of it for the release notes. |
G4Vi
pushed a commit
to G4Vi/cosmopolitan
that referenced
this pull request
Jan 19, 2024
* Implement __zipos_dup Makes ZiposHandle reference-counted by an `rc` field in a union with its freelist `next` pointer. The functions `__zipos_free` and `__zipos_keep` function as incref/decref for it. Adds `__zipos_postdup` to fix metadata on file descriptors after dup-like operations, and adds zipos support to `sys_dup_nt` + `sys_close_nt`. * Remove noop __zipos_postdup rc is never a zipos file because it is always a previously unused file descriptor. fd is never a zipos file because that case has been handled above by __zipos_fcntl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes ZiposHandle reference-counted by an
rcfield in a union with itsfreelist
nextpointer. The functions__zipos_freeand__zipos_keepfunction as incref/decref for it. Adds
__zipos_postdupto fix metadataon file descriptors after dup-like operations, and adds zipos support to
sys_dup_nt+sys_close_nt.