web: Added LETSENCRYPT_ACME_DIRECTORY environment variable #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HighwayStar
commented
Mar 6, 2025
HighwayStar
commented
- you can set it when default zerossl doesnt work for you. For example yor server located in the country blocked by ZeroSSL like described in Failed to obtain a certificate from the Let's Encrypt CA. #2022
saghul
reviewed
Mar 6, 2025
docker-compose.yml
Outdated
| @@ -121,6 +121,7 @@ services: | |||
| - LETSENCRYPT_DOMAIN | |||
| - LETSENCRYPT_EMAIL | |||
| - LETSENCRYPT_USE_STAGING | |||
| - LETSENCRYPT_ACME_DIRECTORY | |||
There was a problem hiding this comment.
I think this variable name is very misleading. acme.sh may implement the feature using a directory, but that's not what the user really wants, they want to change the server. Let's call this LETSENCRYPT_ACME_SERVER.
web/rootfs/etc/cont-init.d/10-config
Outdated
| @@ -19,10 +19,18 @@ if [[ $DISABLE_HTTPS -ne 1 ]]; then | |||
| if [[ $LETSENCRYPT_USE_STAGING -eq 1 ]]; then | |||
| STAGING="--staging" | |||
| fi | |||
|
|
|||
| ACME_DIRECTORY="" | |||
* you can set it when default zerossl doesnt work for you. For example your server located in the country blocked by ZeroSSL
saghul
approved these changes
Mar 6, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.