Skip to content

fix(ci) avoid OOM when building with QEMU #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

fix(ci) avoid OOM when building with QEMU #2096

merged 1 commit into from
May 27, 2025

Conversation

saghul
Copy link
Member

@saghul saghul commented May 26, 2025

We seem to be close to the QEMU memory limit in GHA, that's why actions fail sporadically.

Switch to native builds, aka build amd64 in an amd64 machine and do the same for arm64.

This means we need to push 2 extra tags: foo-amd64 and foo-arm64 and then create a manifest to unite them both.

Ref: docker/build-push-action#621

@saghul saghul requested a review from aaronkvanmeerten May 26, 2025 14:12
@saghul saghul force-pushed the fix-quemu-oom branch 2 times, most recently from c739cb0 to 8819fcd Compare May 27, 2025 12:52
@saghul
Copy link
Member Author

saghul commented May 27, 2025

We need this, despite the other PRs that just landed, since this fixes a different problem:

28.22 E: Could not read from /var/lib/apt/lists/partial/download.***.org_unstable_InRelease - getline (12: Cannot allocate memory)

Copy link
Member

@aaronkvanmeerten aaronkvanmeerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: do we need buildx setup anymore?

@saghul
Copy link
Member Author

saghul commented May 27, 2025

Nit: do we need buildx setup anymore?

Yep, build is deprecated, buildx is the new default.

@saghul
Copy link
Member Author

saghul commented May 27, 2025

In fact, I forgot something, we need to change the driver... one sec.

We seem to be close to the QEMU memory limit in GHA, that's why actions
fail sporadically.

Switch to native builds, aka build amd64 in an amd64 machine and do the
same for arm64.

This means we need to push 2 extra tags: foo-amd64 and foo-arm64 and
then create a manifest to unite them both.

Ref: docker/build-push-action#621
@saghul
Copy link
Member Author

saghul commented May 27, 2025

Updated, PTAL!

@saghul saghul merged commit 17baa95 into master May 27, 2025
2 checks passed
@saghul saghul deleted the fix-quemu-oom branch May 27, 2025 14:37
@saghul
Copy link
Member Author

saghul commented May 27, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants