fix: fix Jansi AnsiConsole broken color detection in uber jars #1305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When migrating from the original Jansi library to JLine's Jansi implementation, colors stopped working in uber jars on Windows (and other platforms). This was reported in issue #1292.
Root Cause
The issue was caused by inverted logic in the
AnsiType
detection withinAnsiConsole.ansiStream()
. The ternary operator was backwards:Technical Details
The logic should be:
getSystemStream() == null
:AnsiType.Redirected
(output is redirected to a file/pipe)getSystemStream() != null
:AnsiType.Native
(native terminal with color support)The inverted logic was incorrectly marking native terminals as redirected, which caused ANSI escape sequences to be stripped instead of being processed for color output.
Impact
This simple but critical fix ensures that:
Testing
The fix has been tested with:
Fixes #1292
Pull Request opened by Augment Code with guidance from the PR author