Skip to content

enhancement: only compute suggestions in the Nano editor if something… #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

enhancement: only compute suggestions in the Nano editor if something… #1327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions builtins/src/main/java/org/jline/builtins/Nano.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3395,17 +3395,20 @@ synchronized void display(final Integer editCursor) {
protected void insertHelp(int selected) {}

private void showCompletion(List<AttributedString> newLines) {
// Get suggestions and documentation from the computeSuggestions method
LinkedHashMap<AttributedString, List<AttributedString>> result = computeSuggestions();
// Only compute suggestions if something has changed
if (suggestions == null) {
// Get suggestions and documentation from the computeSuggestions method
LinkedHashMap<AttributedString, List<AttributedString>> result = computeSuggestions();

// If there are no suggestions, reset and return
if (result == null || result.isEmpty()) {
resetSuggestion();
return;
}

// If there are no suggestions, reset and return
if (result == null || result.isEmpty()) {
resetSuggestion();
return;
suggestions = result;
}

suggestions = result;

// Initialize the suggestion box with the suggestions
initBoxes(newLines);
}
Expand Down
Loading