Skip to content

Avoid anonymous eval #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Avoid anonymous eval #776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/httparty/module_inheritable_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def mattr_inheritable(*args)
@mattr_inheritable_attrs += args

args.each do |arg|
module_eval %(class << self; attr_accessor :#{arg} end)
singleton_class.attr_accessor(arg)
end

@mattr_inheritable_attrs
Expand All @@ -42,14 +42,12 @@ def inherited(subclass)
subclass.instance_variable_set(ivar, instance_variable_get(ivar).clone)

if instance_variable_get(ivar).respond_to?(:merge)
method = <<-EOM
subclass.class_eval <<~RUBY, __FILE__, __LINE__ + 1
def self.#{inheritable_attribute}
duplicate = ModuleInheritableAttributes.hash_deep_dup(#{ivar})
#{ivar} = superclass.#{inheritable_attribute}.merge(duplicate)
end
EOM

subclass.class_eval method
RUBY
end
end
end
Expand Down