bump zstd-jni version, scala version, and release version - #362
Conversation
|
|
||
| val scala3 = "3.3.7" | ||
| val scala3 = "3.7.4" | ||
| // ^ n.b. should always be the current scala LTS release, see |
There was a problem hiding this comment.
as per the line right below this: let's not do this
There was a problem hiding this comment.
I instead bumped to 3.3.8
that supposedly can also fix the sun.misc.Unsafe from lazy-val initialization warnings.
I don't quite understand whether that needs an additional compiler switch? https://github.com/scala/scala3/releases/tag/3.3.8 suggests that this needs some -Y..., but the referenced PR
scala/scala3-lts#637 suggests that this works automatically when targeting newer jdks?
There was a problem hiding this comment.
the way I read the PR, it was initially proposed to work automatically. But reviewers felt that went too far for a LTS dot release and so the compiler option is required.
There was a problem hiding this comment.
downstream (joern et al.) will upgrade to 3.8, so this is fine
| "-deprecation", | ||
| "-feature", | ||
| "--release", "8", | ||
| "--release", "11", |
There was a problem hiding this comment.
is this change still required then? same at the bottom? i mean, doesn't really matter I guess...
3 participants
I don't think this will help our issues with jni warnings on new jdks, nor with the module-info, but still.