fix: validate manifest offset bounds before allocation in Deserialization - #364
Merged
Conversation
max-leuthaeuser
force-pushed
the
max/check-manifest-size
branch
2 times, most recently
from
July 27, 2026 11:35
0384b1b to
b62cea2
Compare
max-leuthaeuser
force-pushed
the
max/check-manifest-size
branch
from
July 27, 2026 11:37
b62cea2 to
8776397
Compare
Ferada
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QT-1269 - Root Cause
When loading a flatgraph file,
readManifestreads an 8-byte little-endian manifest offset from the file header, then computes:If the file is truncated (e.g. interrupted download), the manifest offset stored in the header points beyond the actual end of the file, making
manifestSizea negative Long. Two existing guards both failed to catch this:manifestSize > fileSize— only triggers ifmanifestOffset < 0, which is not the case for a truncated filemanifestSize > Int.MaxValue— a negative Long is never greater thanInt.MaxValueThe negative Long then passes both checks,
.toIntnarrows it to a negativeInt, andByteBuffer.allocate(negativeInt)throws:Fix
Replace the flawed
manifestSize > fileSizeguard with an explicit bounds check onmanifestOffsetitself, beforemanifestSizeis even computed:This produces a clear, actionable error message instead of a cryptic JVM crash deep in buffer allocation.
Verification
Confirmed against the real
cpg.bin.zip(121.5 MB on disk, manifest offset pointing to 348.2 MB):Fixes https://harness.atlassian.net/browse/QT-1269