-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.3] Messages api issue - the webservices API for creating and patching messages is not working #41017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MacJoom
wants to merge
13
commits into
joomla:5.3-dev
Choose a base branch
from
MacJoom:MessagesAPIIssue
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
reviewed
Jun 23, 2023
administrator/components/com_messages/src/Model/MessageModel.php
Outdated
Show resolved
Hide resolved
wilsonge
reviewed
Jun 27, 2023
This pull request has been automatically rebased to 4.4-dev. |
POST and PATCH messages works just noticed |
testing joomla#41017 user_id_from was lost Thank you - no idea why this happened...
I have tested this item ✅ successfully on 32f12ca This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41017. |
This pull request has been automatically rebased to 5.2-dev. |
This pull request has been automatically rebased to 5.3-dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Creating (POST) and editing messages (PATCH) does not work
See https://docs.joomla.org/J4.x:Joomla_Core_APIs - Section Messages, creating and editing messages
Summary of Changes
messages.xml - add message_id to form so it can be passed as valid data
MessageModel - set the message_id key to the input
MessageModel - enable actions on sent and received messages
Testing Instructions
Test sending and receiving Message to other administrators in the backend
Do your own API calls on Message creating and editing
or use my Postman collection https://github.com/MacJoom/j4x-api-collection Section 7.1
Actual result BEFORE applying this Pull Request
Backend: works
API: Creating and editing messages fails
Expected result AFTER applying this Pull Request
Backend: works
API: Creating and editing messages works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[ x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed