[6.0] Feature/collapseable tables

[jduerscheid]

Pull Request for Issue #38335 .

Summary of Changes

Added function for collapsing child item for:

• Menu List View
• Categories List View (used in Category, Newsfeed, Banners)
• Tags List View

Testing Instructions

1. Go to one of the above listed views and create multiple Items with child items in different Levels.
2. Set the listlimmit to All
3. After apply the patch
4. Click to the arrow Buttons in the Table row. The Child items should disapaer and the arraw should trun from down to right
5. Click again to the arrow button, The Child Items should again apear and the arrow turns from right to dowm

Actual result BEFORE applying this Pull Request

No function, because new feature

Expected result AFTER applying this Pull Request

New feature should availible. How it works is described in the Testing Instruction

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

wont setting the list limit to zero create big problems on sites with a lot of categories etc

[jduerscheid]

@brianteeman Do you have a different idea how to solve this? I think in 99.9% it will work really good to list all categories.

[brianteeman]

I have suggested various corrections and bug fixes.

1. change collapsable to collapsible
2. change header to a td not a th
3. fixed copy paste errors in the js comments
4. renamed the storage key

[HLeithner]

I like the idea, but we already wasting so much space for columns... we need a better solution for this.

[richard67]

Back to pending. @chmst Do you know who currently is in the accessibility team and could check this PR?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41557.}

[walturbo]

I have tested this item ✅ successfully on 729442a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41557.}

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[bascherz]

I have tested this item 🔴 unsuccessfully on 729442a

Testing on a fresh 5.2.0-beta1 site with example content installed. After applying the patch and refreshing the menu list view, got the following error that made the list completely inaccessible. This happened on all of the menus. I reviewed the instructions and did not see a step intended to avoid this.

An error has occurred.
0 There is no "table.rows" asset of a "script" type in the registry.
Call Stack

Function Location

1 () JROOT/libraries/src/WebAsset/WebAssetRegistry.php:135
2 Joomla\CMS\WebAsset\WebAssetRegistry->get() JROOT/libraries/src/WebAsset/WebAssetManager.php:274
3 Joomla\CMS\WebAsset\WebAssetManager->useAsset() JROOT/libraries/src/WebAsset/WebAssetManager.php:208
4 Joomla\CMS\WebAsset\WebAssetManager->__call() JROOT/administrator/components/com_menus/tmpl/items/default.php:25
5 include() JROOT/libraries/src/MVC/View/HtmlView.php:416
6 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/libraries/src/MVC/View/HtmlView.php:204
7 Joomla\CMS\MVC\View\HtmlView->display() JROOT/administrator/components/com_menus/src/View/Items/HtmlView.php:283
8 Joomla\Component\Menus\Administrator\View\Items\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
9 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_menus/src/Controller/DisplayController.php:74
10 Joomla\Component\Menus\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
11 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
12 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
13 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
14 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
15 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
16 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
17 require_once() JROOT/administrator/index.php:32

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41557.}

[richard67]

I have tested this item 🔴 unsuccessfully on 729442aTesting on a fresh 5.2.0-beta1 site with example content installed. After applying the patch and refreshing the menu list view, got the following error that made the list completely inaccessible. This happened on all of the menus. I reviewed the instructions and did not see a step intended to avoid this.

An error has occurred. 0 There is no "table.rows" asset of a "script" type in the registry. Call Stack

@bascherz The reason for that is that this PR has a conflict in the relevant file, so it can't really be tested. You can see conflicts by going to the PR on GitHub and scrolling to the bottom.

[bascherz]

@bascherz The reason for that is that this PR has a conflict in the relevant file, so it can't really be tested. You can see conflicts by going to the PR on GitHub and scrolling to the bottom.

This seems to be happening to quite a few of the features I try to test. I will be more observant in subsequent testing.

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[webfeuerflo]

Tested unsuccessfully on 5.3.0-beta. Got the error mentioned above "0 There is no "table.rows" asset of a "script" type in the registry."

[cybersalt]

I have tested this item 🔴 unsuccessfully on 80fe025

I tested this and got the following error:

There is no "table.rows" asset of a "script" type in the registry.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41557.}

[HLeithner]

This pull request has been automatically rebased to 6.0-dev.

[richard67]

The accessibility issues mentioned in this comment further above still have to be fixed: #41557 (comment)