-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Batch Copy & Move tags #41927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
[6.0] Batch Copy & Move tags #41927
Conversation
I have tested this item ✅ successfully on c503b03 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927. |
@chmst isnt this identical to the ui for batch copying and moving menu items?? |
@brianteeman not if I understand this correctly You choose a menuitem in the list (the systems holds the id), opens the batch modal then you choose a target menuitem and decides if you want a copy or move. You must not do this first step and select your item in the batch modal. |
Yes, thanks for explainingt. The language string is the first reason for confusion. But it must be "select a tag". Just open the dropdown. The second is: Why not accept the selection of items to move or copy from the overview? In com_menus and in categories we don't have an extra step for that. Maybe there is something special in tags which requires that? |
@chmst Sorry I dont understand what you are talking about |
I am sorry that I cannot explain. Will try it later with videos. |
@brianteeman you were correct. - it seems that this language string caused the whole confusion and my folloing action was overreaction. |
Sorry for that confusion. I fixed the text and updated the description part of the PR. |
This pull request has been automatically rebased to 5.1-dev. |
This pull request has been automatically rebased to 5.3-dev. |
I have tested this item ✅ successfully on 715e848 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927. |
This pull request has been automatically rebased to 6.0-dev. |
@Hackwar Maybe you can advice with the PHPstan errors for this PR: One can be fixed with |
Pull Request for Issue #23304, only partially.
This PR is based on #38583 and fixes the comments.
Summary of Changes
Adds the ability to batch copy/move tags in the tags list.
Copying a tag also copies its children (same behavior as in other tree models like categories, menues).
Moving a tag also moves its children (same behavior as in other tree models like categories, menues).
For example, it is possible to move a child tag from one parent to another (including its children), or to copy a child tag from one parent to another (including its children).
In the batch tag drop down there is also an item "Root" to move/copy selected tags to the root level.
Changed visualization "Action to Perform" of copy/move action, it is now hidden as long as the user does not touch the select field for copy/move. See example in video below. This change affects batch copy/move dialog of menues and articles as well.
It also fixes a browser console error when the batch dialog is opened and cancel is clicked, on systems where multilingual is disabled.
Testing Instructions
It contains an updated javascript so run: npm run build:js
Initial tag structure for each of the tests below:
Tag1
-Tag2
--Tag3
Tag4
Test 1
Move Tag2 to Tag4 results in:
Tag1
Tag4
-Tag2
--Tag3
Test 2
Move Tag1 to Tag4 results in:
Tag4
-Tag1
--Tag2
---Tag3
Test 3
Copy Tag4 to Tag2 result in:
Tag1
-Tag2
--Tag3
--Tag4 (2)
Tag4
Test 4
Check whether the visualization of "Action to Perform" of copy/move action is first hidden for views like menues, articles. Only if a target item is selected "Action to Perform" appears.
Actual result BEFORE applying this Pull Request
The tags list batch processing does not support copy move.
Expected result AFTER applying this Pull Request
The tags list batch processing supports copy move:
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed