-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Subform Grid layout, an alternative for unresponsive Table layout #42347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
Conversation
@Fedik tested in an own component and really like it. My subform in three variants after Patch: repeatable, repeatable-grid and repeatable-table |
Conflicts: build/media_source/templates/site/cassiopeia/scss/blocks/_form.scss plugins/fields/subform/params/subform.xml
This pull request has been automatically rebased to 5.3-dev. |
I have tested this item ✅ successfully on 9de6e35 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42347. |
This pull request has been automatically rebased to 6.0-dev. |
I have tested this item ✅ successfully on c80752c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42347. |
Really works nicely |
Has this been checked for accessibility? |
I have tested this item ✅ successfully on c80752c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42347. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42347. |
It is a regular fields in grid arrangement nothing fancy, what can go wrong? 😉 |
quite a lot |
Pull Request for Issue #29241.
Summary of Changes
Adds a new layout that rendering subforms fields in Grid (which partially mimic the table look).
Wich make it more responsive.
It is not 1:1 replacement for table, here is no headers and the labels is rendered within the input.
But in most cases should be good for such views.
Testing Instructions
Run
npm install
Create subform field somewhere:
And check that it looks good on small and normal screens.
Also try edit the Custom field options for List field in backend, with browser width around 1000-1200px
Actual result BEFORE applying this Pull Request
The options input for List field is cutted:
Expected result AFTER applying this Pull Request
Testing field works.
The options input for List field looks good:

Link to documentations
Please select:
Please write your opinions.
Do we need this, do we do it in this way or should be something else. Thanks!