[5.4] Schemaorg system plugin onContentAfterDelete issue

[Denitz]

Summary of Changes

Schemaorg system plugin onContentAfterDelete event tries do delete the schema even if context is not supported, and we have a warning if an item doesn't have id attribute.

Testing Instructions

Delete any item of custom component which doesn't implement SchemaorgServiceInterface or doesn't have id attribute.

Actual result BEFORE applying this Pull Request

See a similar warning in error log:

PHP Warning:  Undefined property: Xxx\\Component\\Xxx\\Administrator\\Table\\Xxx::$id in /var/www/public_html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 545

Expected result AFTER applying this Pull Request

No warning, only items which support schemaorg and with ID column are deleted.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[richard67]

Delete any item of custom component which doesn't implement SchemaorgServiceInterface or doesn't have id attribute.

@Denitz Do you know a publicly available example for such an extension? If so, please add that info to your testing instructions. It could make it much easier to find testers for this PR, e.g. at the Pizza, Bugs & Fun (PBF) event tomorrow.

[Denitz]

@richard67 Unfortuntely, I don't remember now what was the origin for this error. It could be Hikashop: the #__hikashop_product table of products has product_id primary key. There is a free starter version.

[richard67]

@Denitz Maybe you know a small extension which could be modified e.g. by changing the context? Or could a core extension like e.g. com_contact be modified in that way for testing?

[Fedik]

I have tested this item ✅ successfully on 6ed047e

On review, calling deleteSchemaOrg() with empty ID does not make sense

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44020.}

[richard67]

I have tested this item ✅ successfully on 6ed047e

Tested by code review. The deleteSchemaOrg method is not called when there is no item id, and regarding the check if the context is supported the behaviour is not changed, only code is optimised to avoid multiple calls for the same thing.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44020.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44020.}

[muhme]

Thank you @Denitz for your contribution. Thank you @Fedik and @richard67 for testing.