[5.3] [Installation][CLI] Fix hidden option asking #44908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@voronkovich have you tested installing Joomla from CLI with the interactive version? Is the public folder appearing as the last question after this change? |
|
@dgrammatiko, I've tested it right now. All works as expected. |
No, sorry. For non trivial PRs which do not just change some comments or so, testing is ALWAYS required, and PR authors are expected to provide testing instructions. |
|
@richard67, I've added testing instructions. |
voronkovich
force-pushed
the
fix-cli-installation-hidden-option-ask
branch
from
5357f40 to
de897c3
Compare
|
This pull request has been automatically rebased to 5.3-dev. |
HLeithner
changed the title
|
I have tested this item ✅ successfully on d1307ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44908. |
|
thanks |
4 tasks
muhme
added a commit
that referenced
this pull request
Apr 15, 2025
There are only changes from PR #44908.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Install command hides input when asking for
--db-passand--admin-passwordvalues. But it also checks for an option--public_folderwhich is a typo.Testing Instructions
Try to install Joomla using CLI:
Ensure that the public folder option appearing as the last question and its value is not hidden.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed