Add file types for media custom field plugin.

[sergeytolkachyov]

When creating a custom field, do you want to be able to select not only images, but also documents, videos, and audio? This PR adds the ability to specify one or more file types for a custom media type field.

Summary of Changes

• The file types parameter was added to the field parameters during creation.
• There are 4 file types: images, audios, videos, documents. This list decides which of the allowed file extensions from Media Manager configuration are used.
• images file type is selected by default and for empty parameter value
• You can select one or several file types: only videos and documents for example
• new attribute for Accessiblemedia Form Field: types. Similar to Media field.

Testing Instructions

• Apply this PR
• Create a new custom field for articles or contacts.
• Look at new field parameter - File types
  
• save your field with default settings (images type is selected)
  
• go to article edit view and try to choose a media file in this field - You'll be able to select only images. This is default Joomla behavior before apply this PR.
  
  See also a modal window title is Change image
  
  See also that the image has been rendered successfully in the frontend
  
• return to field settings and change file types. For example, unselect an images and select a documents or videos or both of them. Save field params,
  
• go to article edit view again and try to select media file in this field. Make sure you can select only documents or only videos as you configured your field. See also a modal window title is Change file
  
  See that there is no alt text and empty alt fields, but new field link text is present
  
• Check that link to download selected file has been rendered successfully in the frontend for documents file types. The link text is download by default. You can specify your own text.
  
• Check that <video> tag for selected file has been rendered successfully in the frontend for video file types.
  
• Check that <audio> tag for selected file has been rendered successfully in the frontend for audio file types.
  
• Go to field settings and change file types and add to file types images. So you have both images and non-images file types selected. Save field params.
  
• Go to article edit view and check that alt text and empty alt fields are present with the link text field. So if you'll select an image file - you can use additional field for image. If you'll select a non-image file - you can use a link text field
  
• Check modal window title is Change file. Check that you can choose both images and non-images file types.
  
  
• Select document file and check that link to download selected file has been rendered successfully in the frontend. Make sure that the link text matches the one specified in the field link text.
  
• Then select image file, fill the alt text for test and check that the image has been rendered successfully in the frontend
  
  

Actual result BEFORE applying this Pull Request

You cannot select anything except images in custom fields,

Expected result AFTER applying this Pull Request

Now you can configure file types for custom field type media (wich is a bundle of media + text for alt + checkbox for empty alt). You can select a mp4 or pdf in your media custom field.

• If image file has been selected - you can use alt text and empty alt fields. Image will render in frontend.
• if audio or video file has been selected - <audio> or <video> tag will render in frontend.
• if document file has been selected - you can use link text field for download link. Download link will render in frontend.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Septdir]

I have tested this item ✅ successfully on 9a36d9b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[gug2]

I have tested this item ✅ successfully on 9a36d9b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[hans2103]

I have tested this item ✅ successfully on 9a36d9b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[sergeytolkachyov]

I have tested this item ✅ successfully on dff217a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[hans2103]

I have tested this item ✅ successfully on dff217a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[sergeytolkachyov]

@hans2103 can you test again, please?

[gug2]

I have tested this item ✅ successfully on dff217a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[viocassel]

I have tested this item ✅ successfully on dff217a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[sergeytolkachyov]

I have tested this item ✅ successfully on 8a2e00b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[gug2]

I have tested this item ✅ successfully on 8a2e00b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[web-eau-net]

I have tested this item ✅ successfully on 8a2e00b

Nice job!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[brianteeman]

I am sorry but unless I misunderstand something this creates a very confusing UI in the admin and broken output in the front end and I dont see how any of you can have tested this successfully

[brianteeman]

I have tested this item 🔴 unsuccessfully on 8a2e00b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45013.}

[brianteeman]

retesting this PR and I find that with this PR applied I am unable to upload an image into the root images folder. No error messages :(/ I can still upload to subdirectories

As soon as I revert this PR I can once again use media manager correctly.

This was an unrelated issue and solved elswhere

[sergeytolkachyov]

From an accessibility perspective the default text for every link is "download" This can result in multiple links on the same page with the exact same details - which is an accessibility failure
An option might be to do it the way we do a read more link. eg Download < Filename >
Tagging @chmst for their a11y input

This accessibility failure must be resolved

Local pdf:

Remote pdf:

Frontend

[sergeytolkachyov]

@rdeutz can I do anything else for this PR?

[sergeytolkachyov]

@QuyTon can I do anything for this PR? I forgot make a separate branch for PR and then I can't do another one till this PR will be merged ((

[sergeytolkachyov]

@QuyTon @rdeutz @brianteeman @laoneo Joomla 6.0.0 beta1 is coming in 2 days. It means a feature freeze for J6. This PR was succesfully tested and marked as update requested - so it should not be tested again. Is there anything else required for this PR? It has been opened in february...

[brianteeman]

the people to tag are the release leads @softforge @Bodge-IT

[sergeytolkachyov]

the people to tag are the release leads @softforge @Bodge-IT

Thank you!

[Bodge-IT]

Hi @sergeytolkachyov, this only hit our radar on Sunday and we were locked by then. We had opinion this still needed resolutions.

[sergeytolkachyov]

Hi @sergeytolkachyov, this only hit our radar on Sunday and we were locked by then. We had opinion this still needed resolutions.

Can I do anything for this pr or it will wait for j6.1?

[softforge]

Hi @sergeytolkachyov, this only hit our radar on Sunday and we were locked by then. We had opinion this still needed resolutions.

Can I do anything for this pr or it will wait for j6.1?
We are looking into it and will have a decision tomorrow, but appreciate the work you have done to date, thank you

[sergeytolkachyov]

We are looking into it and will have a decision tomorrow, but appreciate the work you have done to date, thank you

If you have any questions, feel free to ask me. I myself see several potential ways to improve consistency, but this will generally require discussion with other developers before implementation.

[softforge]

Dear @sergeytolkachyov, first, thank you for all your work and patience so far.
We had a look through the code and see there are still some comments to be resolved, and then testing as there have been commits since the last tests.
Beta 1 has passed, so we cannot include it, but we would like to work with you over the next few weeks to get any comments satisfied and then test it in PBF if it's ready for that or straight after, and to help you get it into 6.1 early so you are not waiting 6 months for a decision but it could be one of the first things ready for the 6.1 managers to merge