[5.3] Remove useless empty ($form) check

[joomdonation]

Pull Request for Issue # .

Summary of Changes

The loadForm method from FormBehaviorTrait (which is used by our models) always return a Form object on success and throw Exception on failure, so all empty($form) check in our model classes are useless, it never returns false, thus should be moved from models code.

Testing Instructions

This will require careful code review from our testers and maintainer.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, slight faster because the useless code is removed, thus not being executed.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[exlemor]

@joomdonation Can you please provide testing instructions - how can we test this? - 58 files in code review may not be enough.

Love to include it in PBF which is today :)

[joomdonation]

Thanks @exlemor. This is too late to be included in 5.3, so please ignore it for now. I will try to make it for Joomla 6 later.