Skip to content

[5.3] Infinite API loop if site is offline and requesting unknow resource #45576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

Flowman
Copy link
Contributor

@Flowman Flowman commented Jun 8, 2025

Pull Request for Issue # .

Summary of Changes

If the site is in offline mode and an API resource is requested that doesn't exist, Joomla enters an infinite redirect loop.

To address this, the existing error handling code that checked for CLI issues was updated to include a check for API requests too.

Testing Instructions

Put site in offline mode.

Try to access https://test.com/api/index.php

Actual result BEFORE applying this Pull Request

Infinite 303 redirects.

Expected result AFTER applying this Pull Request

It show the 404 error json data.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 added the bug label Jun 10, 2025
@exlemor exlemor added the PBF Pizza, Bugs and Fun label Aug 23, 2025
@crimle
Copy link

crimle commented Aug 23, 2025

I have tested this item ✅ successfully on 2559dbb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45576.

@MacJoom
Copy link
Contributor

MacJoom commented Aug 23, 2025

I have tested this item ✅ successfully on 2559dbb

On 5.3.3 - successful


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45576.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45576.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PBF Pizza, Bugs and Fun PR-5.3-dev RTC This Pull Request is Ready To Commit Webservices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants