[5.3] Infinite API loop if site is offline and requesting unknow resource #45576
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
If the site is in offline mode and an API resource is requested that doesn't exist, Joomla enters an infinite redirect loop.
To address this, the existing error handling code that checked for CLI issues was updated to include a check for API requests too.
Testing Instructions
Put site in offline mode.
Try to access https://test.com/api/index.php
Actual result BEFORE applying this Pull Request
Infinite 303 redirects.
Expected result AFTER applying this Pull Request
It show the 404 error json data.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed