-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0][webservices] cannot delete not trashed resource return 409 #45868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alikon
wants to merge
13
commits into
joomla:6.0-dev
Choose a base branch
from
alikon:patch-26
base: 6.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on 9b475e6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45868. |
I have tested this item ✅ successfully on 4fbb57e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45868. |
I have tested this item ✅ successfully on 4fbb57e Same positive results :D This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45868. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #45590 .
Summary of Changes
return HTTP status code 409 instead of 500
add a system test
Testing Instructions
delete not-trashed resource like: tag, category, article etc via webservices DELETE endpoint
Actual result BEFORE applying this Pull Request
HTTP status code 500 and error message "Internal server error".
Expected result AFTER applying this Pull Request
HTTP status code 409 with informative message like : Resource not in state that can be deleted, must be trashed before it can be deleted
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed