Skip to content

[5.4] Update OpenLDAP container image in CI workflow to use own mirror image #45912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025

Conversation

LadySolveig
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

As we reach the rate limit on docker hub for the tests. This should only be a proof of concept if we could use a mirror image from the Github registry for the OpenLDAP image.

grafik

Testing Instructions

Running automated tests.

Actual result BEFORE applying this Pull Request

Tests are blocked by rate limit.

Expected result AFTER applying this Pull Request

Tests can run again.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig LadySolveig marked this pull request as ready for review August 14, 2025 14:29
@richard67 richard67 changed the title Update OpenLDAP container image in CI workflow to use own mirror image [5.4] Update OpenLDAP container image in CI workflow to use own mirror image Aug 14, 2025
@richard67
Copy link
Member

richard67 commented Aug 14, 2025

I have tested this item ✅ successfully on 92709ae

The step "Start LDAP container" in the integration tests uses our mirror image.

No rate limit happens.

In comparison, the same fails for PR #45910 due to the rate limit for the LDAP download, as we have it occasionally seen for other PRs.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45912.

@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 92709ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45912.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45912.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 15, 2025
@muhme
Copy link
Contributor

muhme commented Aug 15, 2025

✅ Final check before merge:

  • Docker error toomanyrequests: You have reached your unauthenticated pull rate limit. seen this morning in 5.4-dev branch
  • GitHub action Run integration tests > Start LDAP container works with own cloned Docker image in this PR

@muhme muhme merged commit 4c8ea6b into joomla:5.4-dev Aug 15, 2025
41 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 15, 2025
@muhme
Copy link
Contributor

muhme commented Aug 15, 2025

Thank you @LadySolveig for your contribution. Thank you @richard67 and @bembelimen for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants