Skip to content

[5.3] db prefix #45920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

[5.3] db prefix #45920

merged 2 commits into from
Aug 20, 2025

Conversation

brianteeman
Copy link
Contributor

The error message if you enter an invalid db prefix is not clear that it MUST end with an underscore

Testing Instructions

Use the web installer and set a db prefix of abc

Use the cli installer and set a db prefix of abc

Actual result BEFORE applying this Pull Request

image image

Expected result AFTER applying this Pull Request

image image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

The error message if you enter an invalid db prefix is not clear that it MUST end with an underscore
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Aug 15, 2025
@alikon
Copy link
Contributor

alikon commented Aug 17, 2025

I have tested this item ✅ successfully on f2be72f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45920.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on f2be72f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45920.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45920.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 17, 2025
@rdeutz rdeutz enabled auto-merge (squash) August 20, 2025 16:20
@rdeutz
Copy link
Contributor

rdeutz commented Aug 20, 2025

Thanks

@rdeutz rdeutz merged commit fa7e100 into joomla:5.3-dev Aug 20, 2025
39 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 20, 2025
@brianteeman brianteeman deleted the patch-2 branch August 20, 2025 17:11
@Kostelano
Copy link
Contributor

Please add the appropriate version of milestone

@brianteeman
Copy link
Contributor Author

@rdeutz can you add the milestone please

@richard67 richard67 added this to the Joomla! 5.3.4 milestone Aug 22, 2025
@richard67
Copy link
Member

Done

@brianteeman
Copy link
Contributor Author

thanks @richard67 and also to @tecpromotion for correcting some others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants