[6.0] Version fixes #45955
Draft
[6.0] Version fixes #45955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
Aug 21, 2025
| return $result; | ||
| } | ||
|
|
||
| // Legacy code for history concept before 6.0.0, depeciated 6.0.0 will be removed with 8.0.0 |
There was a problem hiding this comment.
Suggested change
| // Legacy code for history concept before 6.0.0, depeciated 6.0.0 will be removed with 8.0.0 | |
| // Legacy code for history concept before 6.0.0, deprecated 6.0.0 will be removed with 8.0.0 |
brianteeman
reviewed
Aug 21, 2025
| @@ -24,6 +30,22 @@ | |||
| */ | |||
| trait VersionableModelTrait | |||
| { | |||
| /** | |||
| * Fields to be ignored when calculation the hash. | |||
There was a problem hiding this comment.
Suggested change
| * Fields to be ignored when calculation the hash. | |
| * Fields to be ignored when calculating the hash. |
brianteeman
reviewed
Aug 21, 2025
| protected $ignoreChanges = []; | ||
|
|
||
| /** | ||
| * Fields to be converted to int when calculation the hash. |
There was a problem hiding this comment.
Suggested change
| * Fields to be converted to int when calculation the hash. | |
| * Fields to be converted to int when calculating the hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #45515 to fix know issues
Summary of Changes
Cleanup and fix know issues
Testing Instructions
Will follow
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed