Skip to content

[5.4] Improve defining email recipients for update notification #45960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: 5.4-dev
Choose a base branch
from

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Aug 21, 2025

Follow-up for PR #45721

Summary of Changes

Until now, recipients of update notifications are defined as a comma separated list of email addresses.
This means: First find the email-addresses of super users, then maintain the list when super users leave or are added or when they change emailaddress.

This PR works like in AutoUpdate notification: #45721

All Super Users get the update notification. Additionally other user groups can be added. Recipients must be active and have the sendEmail Option allowed.

The Updatescript will remove the old email option from parameters in the table. If there were old entries, they will be deleted. These entries were a subset of super users, so there is no break.

Testing Instructions

  1. Run the update script. The mysql script is tested, the postgresql script is generated by AI and needs a tester with these skills.

  2. Make different users, different user groups, they can be empty, have super users not, have sendEmail activated or not and can be blocked or not.

  3. Go to scheduled tasks and open the Update Notification Plugin. Check if user Groups can be added.

  4. Testing if the email addresses now are correct is tricky.

Actual result BEFORE applying this Pull Request

Comma separated list of super users or the super user (id = 8) per default
grafik

Expected result AFTER applying this Pull Request

It is possible to select user groups from a list. Super Users are added per default and must notr be selected.
grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: [(https://docs.joomla.org/J3.x:Plugin_Joomla_Update_Notification#Super_User_Email]

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.4-dev labels Aug 21, 2025
@brianteeman
Copy link
Contributor

Do I read this correct.

Before this PR a site owner could set a limited number of super users to receive this specific email but now all super users will receive the email.

If I read it correctly and this is the case then this is a change in behaviour on an existing site that should not happen in a minor release

@chmst
Copy link
Contributor Author

chmst commented Aug 22, 2025

I made this as draft, so we can discuss.
We should have equal behaviour here and for automaded update notifications.

If we don't want to inform all super users, then we could make a users selection of all users who have the super user rights or sendEmail option = "on".
On the one hand it is better if only one super user is responsible, on the other hand it could be that nobody gets a notification, as it is now when super users change.

I am ok with J6.0, release managers can decide.

@brianteeman
Copy link
Contributor

My only concern is that this proposes a change of behaviour on existing sites with no notification

@travisrisner
Copy link
Contributor

What if there is another parameter using a radio for "Send to list of email addresses" or "Send to user groups" (probably different wording). Both comma separated list and group selection fields can exist and be toggled with a showon. By default it keeps the comma separated list on so it doesn't break current installations, but still allows you to set the functionality to send to a group instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants