-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Github Codespaces Patch #45961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
[6.0] Github Codespaces Patch #45961
Conversation
Would this mean that it works only on https? Does it also need an update of the manual? |
It was working only on http (port 80), with this pr it works on both http (port 80) and https (port 443)
I guess so, just a few lines to clarify. |
the Mfa.cy.js test now doesn't fail anymore what i've noticed is that the configuration.php is not writable so you cannot change some settings in Global configuration |
Do we need port 3306 for MySQL to the outside? I think it is only needed inside the docker network at the moment. Personally, I see it as best practice to only expose the ports to the outside that are really needed from the outside. Not a bug but maybe a consideration |
Just added a couple of lines in the docs for this, joomla/Manual#505
I changed them like your comment said, but this change makes the CI checks fail on this repo, so I might need to revert those changes and just ignore ![]() now we got all Cypress tests passing successfully
After some debugging, I found out it was caused by |
Pull Request for Issue # .
Summary of Changes
This PR is a quick patch for github codespaces feature, #45719
Mfa.cy.js
tests to failTesting Instructions
see joomla/Manual#496
Actual result BEFORE applying this Pull Request
Mfa.cy.js
tests fail, error when rebuilding the container (it says configuation.php already exists), no error logs for phpExpected result AFTER applying this Pull Request
Mfa.cy.js
tests pass and https support is added, no errors when rebuilding the container, error logs available for phpLink to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Github Codespaces Patch Manual#505
No documentation changes for manual.joomla.org needed