Skip to content

Remove rexml - rexml broken in Ruby versions below 2.3 #1800

@jordansissel

Description

@jordansissel

Another game to play just like #1795. This time, it's rexml.

rexml is a direct dependency in fpm and is used by only one place, osxpkg.rb

https://github.com/jordansissel/fpm/blob/master/lib/fpm/package/osxpkg.rb#L107

It looks like this code is only used when fpm -s osxpkg ... (using an osx package as source/input to fpm).

I'm guessing we can probably remove rexml and parse the xml ourselves without a library.

pkginfo_elem = doc.elements["pkg-info"]
identifier = pkginfo_elem.attribute("identifier").value
self.version = pkginfo_elem.attribute("version").value

It's used to grab the attributes from what looks like <pkg-info identifier="..." version="..."> element.

Reference: #1784 and #1798

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions