Skip to content

[Fix]: coins weren't considered for unlocking ships and weapons #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

Johann4002herti
Copy link
Contributor

✅ PR Checklist

Tip

Please check the boxes below to confirm you followed the contribution guidelines:

  • My PR title follows the format: [Type]: clear description of change
  • I used the correct type: Feature, Fix, Refactor, Docs, Test, Chore
  • I reviewed my code and removed unnecessary debug logs or comments.
  • I tested my changes and verified they work as expected.
  • I ran the project to confirm it compiles and runs correctly.
  • I read the Code of Conduct and the Contribution Guidelines.

📝 What does this PR do?

  • fixed Bug
  • coins weren't considered unlocking ships and weapons, so you only could unlock the two first ships
  • added an declaration of totalCoins in ShipUnlockChecker and WeaponUnlockChecker

🔗 Related Issue

Link to the issue this PR addresses (if any)

  • This PR fixes/closes: #
  • This PR doesn’t address a specific issue.

📸 Screenshots / Demos (if applicable)

Here a video of the Bug before:

Bildschirmaufnahme.2025-05-08.102254.mp4

Here a video of fixed version:

Bildschirmaufnahme.2025-05-08.105706.mp4

💬 Extra Notes (Optional)

Note

🦕 No extra notes.


❤️ Thanks again for your contribution to Dinosaur Exploder!
Your efforts help make this project awesome for everyone. 🦖✨

Copy link

github-actions bot commented May 8, 2025

Build preview 🚀

badge

Thanks for your contribution to this open-source project! ❤️

A new build has been generated for this pull request:

  • 🎮 Game Artifacts: 🐧 Linux / 🍎 macOS / 🪟 Windows
  • 🧪 Workflow Run: View Logs
  • 🔖 Commit: f57b3803930350ebb38f4d3d6d9b0fbde16b333f

Tip

This JAR lets you test the latest version of the game from this PR.

Note: Artifacts auto-expire after ~90 days.

Happy testing & enjoy the game! 🎮

The DinoBot Team 🦖

@jvondermarck
Copy link
Owner

Hello, thanks for this PR, I am sorry, there are some conflicts with the main branch, can you give a look please ? Thanks !!

@jvondermarck jvondermarck added the status: pending-conflict-resolution Wait the author to resolve the conflicts before merging label May 8, 2025
# Conflicts:
#	src/main/java/com/dinosaur/dinosaurexploder/utils/ShipUnlockChecker.java
#	src/main/java/com/dinosaur/dinosaurexploder/utils/WeaponUnlockChecker.java
Copy link
Owner

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I resolved myself the issue !

@jvondermarck jvondermarck merged commit 729c6ec into jvondermarck:main May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending-conflict-resolution Wait the author to resolve the conflicts before merging
Projects
Development

Successfully merging this pull request may close these issues.

2 participants