Skip to content

fix : Green Dinos Now Dynamically Update Speed Based on LevelManager #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Keerthi421
Copy link
Contributor

@Keerthi421 Keerthi421 commented May 8, 2025

✅ PR Checklist

  • My PR title follows the format: [Type]: clear description of change
  • I used the correct type: Feature, Fix, Refactor, Docs, Test, Chore
  • I reviewed my code and removed unnecessary debug logs or comments.
  • I tested my changes and verified they work as expected.
  • I ran the project to confirm it compiles and runs correctly.
  • I read the Code of Conduct and the Contribution Guidelines.

📝 What does this PR do?

->Adds a LevelManager reference to green dinosaurs so they can dynamically update speed based on the current level.
->Ensures green dinos move and shoot faster as levels increase, reflecting the latest level stats.
->Aligns green dino behavior with the robust pattern already used for red dinos, but in a more flexible and future-proof way.

🔗 Related Issue

This PR fixes/closes: #192

Copy link

github-actions bot commented May 8, 2025

Build preview 🚀

badge

Thanks for your contribution to this open-source project! ❤️

A new build has been generated for this pull request:

  • 🎮 Game Artifacts: 🐧 Linux / 🍎 macOS / 🪟 Windows
  • 🧪 Workflow Run: View Logs
  • 🔖 Commit: d3852ba8aea458fa67e0744123790f7c3e18350b

Tip

This JAR lets you test the latest version of the game from this PR.

Note: Artifacts auto-expire after ~90 days.

Happy testing & enjoy the game! 🎮

The DinoBot Team 🦖

Copy link
Owner

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !! Just some conflicts !!

@jvondermarck jvondermarck added the status: pending-conflict-resolution Wait the author to resolve the conflicts before merging label May 8, 2025
@jvondermarck
Copy link
Owner

There are still some conflicts. @Keerthi421 Please pull the latest changes on the main branch of the origin repo and merge it into your local branch.

@jvondermarck jvondermarck added the status: invalid This doesn't seem right label Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid This doesn't seem right status: pending-conflict-resolution Wait the author to resolve the conflicts before merging
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: moving and shoot speed don't increase with level up
2 participants