Skip to content

[Feature]: Added level progress bar #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

powerpuff-luv
Copy link
Contributor

✅ PR Checklist

Tip

Please check the boxes below to confirm you followed the contribution guidelines:

  • My PR title follows the format: [Type]: clear description of change
  • I used the correct type: Feature, Fix, Refactor, Docs, Test, Chore
  • I reviewed my code and removed unnecessary debug logs or comments.
  • I tested my changes and verified they work as expected.
  • I ran the project to confirm it compiles and runs correctly.
  • I read the Code of Conduct and the Contribution Guidelines.

📝 What does this PR do?

  • This PR adds a Level Progress Bar to the game, which shows the progress of regular levels, and hides during boss levels.
  • The Progress Bar requires a Level Manager to be created first, so it is important that now in the DinosaurController class in the initGame() method the levelManager is created first, and only then all Game Entities.

🔗 Related Issue

📸 Screenshots / Demos (if applicable)

DinosaurExlporedLevelProgressBar.mp4

💬 Extra Notes (Optional)

Note

🦕 No extra notes.


❤️ Thanks again for your contribution to Dinosaur Exploder!
Your efforts help make this project awesome for everyone. 🦖✨

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @powerpuff-luv, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
  • ✅ Verify that you have well fill out the different checkboxes in the PR template.
  • ⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.
  • 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

Copy link
Owner

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it, great idea BUT on your video you can see a bug, when you go to level 2, the text takes some seconds to update from "Level 1" to "Level 2" so it is very weird. Can you fix this ? Otherwise great work.

You can see it on your screen recording at 00:05 seconds

Copy link

github-actions bot commented May 12, 2025

Build preview 🚀

badge

Thanks for your contribution to this open-source project! ❤️

A new build has been generated for this pull request:

  • 🎮 Game Artifacts: 🐧 Linux / 🍎 macOS / 🪟 Windows
  • 🧪 Workflow Run: View Logs
  • 🔖 Commit: 66b93d3af0cb771a42366e1ae6cc68d5d190f5c0

Tip

This JAR lets you test the latest version of the game from this PR.

Note: Artifacts auto-expire after ~90 days.

Happy testing & enjoy the game! 🎮

The DinoBot Team 🦖

@jvondermarck jvondermarck added the status: pending-request-changes Request changes from the contributor label May 12, 2025
@powerpuff-luv
Copy link
Contributor Author

DinosaurExploder.mp4

I fixed a bug, now the progress bar remains filled until the next level starts.
I also added animations for the progress bar updates.

But there is something important.
During the two-second pause between levels, LevelManager records all hits made by player. And by the time the next level starts, the progress of that level may not be zero, as shown at the end of the video.

It even looks like it was meant to be that way. In any case, it looks like the progress bar work is finished.

@jvondermarck jvondermarck removed the status: pending-request-changes Request changes from the contributor label May 13, 2025
Copy link
Owner

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now, thank you so much !

@jvondermarck jvondermarck merged commit 1e43ef6 into jvondermarck:main May 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[Feature]: Display the progess of the current level
2 participants