-
-
Notifications
You must be signed in to change notification settings - Fork 96
[Feature]: Added level progress bar #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @powerpuff-luv, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with the repository
/dinosaur-exploder
main
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
- ✅ Verify that you have well fill out the different checkboxes in the PR template.
⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.- 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it, great idea BUT on your video you can see a bug, when you go to level 2, the text takes some seconds to update from "Level 1" to "Level 2" so it is very weird. Can you fix this ? Otherwise great work.
You can see it on your screen recording at 00:05 seconds
Build preview 🚀Thanks for your contribution to this open-source project! ❤️ A new build has been generated for this pull request:
Tip This JAR lets you test the latest version of the game from this PR. ⏳ Note: Artifacts auto-expire after ~90 days. Happy testing & enjoy the game! 🎮 The DinoBot Team 🦖 |
…nimation for level progress bar updates.
DinosaurExploder.mp4I fixed a bug, now the progress bar remains filled until the next level starts. But there is something important. It even looks like it was meant to be that way. In any case, it looks like the progress bar work is finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now, thank you so much !
✅ PR Checklist
Tip
Please check the boxes below to confirm you followed the contribution guidelines:
[Type]: clear description of change
type
: Feature, Fix, Refactor, Docs, Test, Chore📝 What does this PR do?
🔗 Related Issue
📸 Screenshots / Demos (if applicable)
DinosaurExlporedLevelProgressBar.mp4
💬 Extra Notes (Optional)
Note
🦕 No extra notes.
❤️ Thanks again for your contribution to Dinosaur Exploder!
Your efforts help make this project awesome for everyone. 🦖✨