-
-
Notifications
You must be signed in to change notification settings - Fork 96
[Bug/Feature] : AudioManager integration on game screens #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Bug/Feature] : AudioManager integration on game screens #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @santiagoOrozco-encora, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with the repository
/dinosaur-exploder
main
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
- ✅ Verify that you have well fill out the different checkboxes in the PR template.
⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.- 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
Build preview 🚀Thanks for your contribution to this open-source project! ❤️ A new build has been generated for this pull request:
Tip This JAR lets you test the latest version of the game from this PR. ⏳ Note: Artifacts auto-expire after ~90 days. Happy testing & enjoy the game! 🎮 The DinoBot Team 🦖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I still have the same issue when I navigate screen by screen, the audio is still reset every time so I don't know what changed ? I don't notice any difference, maybe share a screen recording to make me understand. Sorry
Hello, there was some screens where the audio was complety lost, and the audio settings were not being saved and used, they used to reset on every screen, I didn't understand that we were looking for the continuity of the sound, but I can definitly work on it, I'll update soon |
✅ PR Checklist
[Type]: clear description of change
type
: Feature, Fix, Refactor, Docs, Test, Chore📝 What does this PR do?
This PR continues with the implementation of the AudioManager of the PR #207 , it integrates the manager on all game screens and remove bugs where in the navigation between screens sometimes it'd loose the audio, as well it saves and use the audio settings saved from the last time when the game is launched again matching the volume slider.
🔗 Related Issue
📸 Screenshots / Demos (if applicable)
Note
🦖 No screenshots or demo provided.
💬 Extra Notes (Optional)
Note
🦕 No extra notes.