Skip to content

[Bug/Feature] : AudioManager integration on game screens #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

santiagoOrozco-encora
Copy link

✅ PR Checklist

  • My PR title follows the format: [Type]: clear description of change
  • I used the correct type: Feature, Fix, Refactor, Docs, Test, Chore
  • I reviewed my code and removed unnecessary debug logs or comments.
  • I tested my changes and verified they work as expected.
  • I ran the project to confirm it compiles and runs correctly.
  • I read the Code of Conduct and the Contribution Guidelines.

📝 What does this PR do?

This PR continues with the implementation of the AudioManager of the PR #207 , it integrates the manager on all game screens and remove bugs where in the navigation between screens sometimes it'd loose the audio, as well it saves and use the audio settings saved from the last time when the game is launched again matching the volume slider.

  • ...

🔗 Related Issue

Link to the issue this PR addresses (if any)

📸 Screenshots / Demos (if applicable)

Note

🦖 No screenshots or demo provided.

💬 Extra Notes (Optional)

Note

🦕 No extra notes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @santiagoOrozco-encora, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
  • ✅ Verify that you have well fill out the different checkboxes in the PR template.
  • ⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.
  • 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

Copy link

Build preview 🚀

badge

Thanks for your contribution to this open-source project! ❤️

A new build has been generated for this pull request:

  • 🎮 Game Artifacts: 🐧 Linux / 🍎 macOS / 🪟 Windows
  • 🧪 Workflow Run: View Logs
  • 🔖 Commit: 233a63c775a07cefb8fc669f5586ddd58353fd03

Tip

This JAR lets you test the latest version of the game from this PR.

Note: Artifacts auto-expire after ~90 days.

Happy testing & enjoy the game! 🎮

The DinoBot Team 🦖

Copy link
Owner

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I still have the same issue when I navigate screen by screen, the audio is still reset every time so I don't know what changed ? I don't notice any difference, maybe share a screen recording to make me understand. Sorry

@jvondermarck jvondermarck added the status: help-wanted Extra attention is needed label Jul 20, 2025
@santiagoOrozco-encora
Copy link
Author

Hey, I still have the same issue when I navigate screen by screen, the audio is still reset every time so I don't know what changed ? I don't notice any difference, maybe share a screen recording to make me understand. Sorry

Hello, there was some screens where the audio was complety lost, and the audio settings were not being saved and used, they used to reset on every screen, I didn't understand that we were looking for the continuity of the sound, but I can definitly work on it, I'll update soon
:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help-wanted Extra attention is needed
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: audio Controls Lose State After Screen Navigation
2 participants