fix: duplicate error message in responses and panic risk in OTEL env vars#2029
Merged
EItanya merged 1 commit intoJun 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refines error handling in the HTTP error middleware to distinguish between API-facing messages and underlying errors, and modernizes OTEL env var parsing by switching from strings.SplitN to strings.Cut.
Changes:
- Separate “underlying” error from API error message for logging and response composition.
- Avoid logging
pgx.ErrNoRowsas an error by checking the underlying error. - Simplify env var parsing using
strings.Cut.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go/core/internal/httpserver/middleware_error.go | Adjusts logging and JSON response composition based on an extracted underlying error. |
| go/core/internal/controller/translator/agent/adk_api_translator.go | Replaces SplitN parsing with Cut for OTEL env var name/value extraction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
bug
mesutoezdil
force-pushed
the
fix/error-response-otel-panic
branch
from
9cdcbb6 to
0fc6d77
Compare
…vars Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
fix/error-response-otel-panic
branch
from
d79fa87 to
58d00ce
Compare
EItanya
reviewed
Jun 17, 2026
| )) | ||
|
|
||
| // Sort by environment variable name | ||
| var envVars []corev1.EnvVar |
Contributor
There was a problem hiding this comment.
Super mega nit: you know the capacity of this slice up front
EItanya
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 bugs fixed in one commit.
RespondWithErrorwas producing"message: message"whenAPIError.Erris nil.Track the underlying error separately and omit the suffix when nil.
collectOtelEnvFromProcessaccessedparts[1]without a bounds check.Replaced with
strings.Cut, consistent with the rest of the codebase.