Setting "debounceValidate" on field record within "Form.registerField" diverges the field record

[kettanaito]

Environment

• react-advanaced-form: 1.0.0

What

There is an issue that debounceValidate is set on the field record within Form.registerField method. Because of that, the internal Field's this.contextProps reference contains no such property on the field record at all. Apparently, relying on componentWillUpdate is not safe, since right now I am able to reproduce the situation when onChange validation throws due to missing fieldRecord.debounceValidate function.

How

I see two solutions to this:

1. Set debounceValidate on Field.register and just read it in Form.registerField
2. Or, have a fallback validator function in case fieldRecord.debounceValidate is undefined.

Perhaps, combining the two is also quite possible.

[kettanaito]

I decided not to go for any fallback logic since that contradicts a single source of truth paradigm, which should be a field's record upon its registration. All the essential data must be set during the Field.register method for two reasons:

1. It must return a full and real field record Map which is used as an assumed field context props during the initial mount and render.
2. It must serve as a single source of truth, making it clear which properties are set on the field record upon its registration.

The fix is passing the tests, so I am going to create a pull request for this today.

[kettanaito]

The fix is merged and awaiting for the next patch release.

[kettanaito]

Published under 1.0.1. Closing.