Skip to content

[css] >3:1 contrast on borders + better hr styling #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Conversation

lkhrs
Copy link
Collaborator

@lkhrs lkhrs commented Sep 23, 2022

Fixes #115

@netlify
Copy link

netlify bot commented Sep 23, 2022

Deploy Preview for simplecss-cdn ready!

Name Link
🔨 Latest commit cb100f0
🔍 Latest deploy log https://app.netlify.com/sites/simplecss-cdn/deploys/633acd9ad1241b00097ac793
😎 Deploy Preview https://deploy-preview-117--simplecss-cdn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lkhrs
Copy link
Collaborator Author

lkhrs commented Sep 23, 2022

I need to work on the hover state for the header links (not distinct enough), marking draft for now.

@lkhrs lkhrs marked this pull request as ready for review September 24, 2022 20:06
@lkhrs lkhrs requested a review from kevquirk September 24, 2022 20:06
@lkhrs
Copy link
Collaborator Author

lkhrs commented Sep 24, 2022

Hi @kevquirk! I'd like you to take a look at the changes for the border color before I merge them (I'll take care of the conflicts). For the nav buttons, I changed the hover color to use the --accent variable instead, similar to the active page state on the project site.

@lkhrs lkhrs closed this Oct 2, 2022
@lkhrs lkhrs deleted the 115 branch October 2, 2022 23:01
@lkhrs lkhrs restored the 115 branch October 3, 2022 00:17
@lkhrs lkhrs reopened this Oct 3, 2022
@lkhrs lkhrs merged commit a376bd3 into kevquirk:main Oct 3, 2022
@lkhrs lkhrs deleted the 115 branch October 3, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal rules could probably do with more spacing
1 participant