feat(helm): add auto-environment values to k8s-reporter chart#1031
Merged
Conversation
mbevc1
enabled auto-merge (squash)
July 24, 2026 16:23
Contributor
|
Claude finished @mbevc1's task in 1m 36s —— View job PR Review: Helm auto-environment values
Reviewed the chart changes against the CLI. This is a clean, well-scoped follow-up to #1028 and the earlier review feedback has all been incorporated. ✅ Verification
Observations (non-blocking)
Nits
Nice, careful work — the tri-state scaling handling and the quoting fixes in particular are exactly right. LGTM pending the CLI |
mbevc1
force-pushed
the
20260724_helm_auto_env
branch
from
July 24, 2026 17:14
0b94b2d to
7513d38
Compare
Expose the CLI's `--auto-environment` flag and its companion flags (`--environment-description`, `--include-scaling`, `--exclude-scaling`) as `reporterConfig.*` values on the k8s-reporter chart, so the reporter CronJob can auto-create Kosli environments (type K8S) on first run without editing the chart. Chart version bumped to 2.6.0 and the values table in README regenerated.
Make reporterConfig.includeScaling nullable (default `null`) so it maps to all three CLI states: unset omits both scaling flags (Kosli server default), true passes `--include-scaling`, and false passes `--exclude-scaling`. The template uses `kindIs "invalid"` to tell an unset value apart from an explicit false, so autoEnvironment no longer forces a scaling flag. Also whitespace-trims the auto-environment arg block so it renders cleanly.
Clarify in the value help text that environmentDescription and
includeScaling apply to every environment auto-created in a single run,
that a single description is shared by all of them, and that existing
environments are never modified (the CLI ignores these flags for envs
that already exist).
Also normalise the args block whitespace: the dryRun and httpProxy
conditionals now use {{- trim markers like the auto-environment block,
so the rendered manifest has no stray blank lines.
Guard the scaling flag with `kindIs "bool"` instead of `not (kindIs "invalid" ...)`. A string value (e.g. from `--set-string reporterConfig.includeScaling=false` or a quoted `includeScaling: "false"`) is Go-template truthy whenever non-empty, which previously emitted --include-scaling regardless of the intended value. Requiring a genuine boolean means any non-bool falls back to the safe "unset -> server default" path.
mbevc1
force-pushed
the
20260724_helm_auto_env
branch
from
July 24, 2026 17:30
64be161 to
c058258
Compare
AlexKantor87
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--auto-environmentflag and its companion flags(
--environment-description,--include-scaling,--exclude-scaling)as
reporterConfig.*values on the k8s-reporter chart, so the reporterCronJob can auto-create Kosli environments (type K8S) on first run
without editing the chart.
2.34.0--auto-environmentflag to kosli snapshot #1028