Fix deadlock when using EJS templates in watch mode #1421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS 15.4.1 if you are using EJS templates in watch mode Sourcery deadlocks after a few template changes because the of work JavaScriptCore attempts to do on the main thread when cleaning up old resources.
Since JavaScriptCore is not easily debuggable its hard to say exactly what is happening but it appears that
JSContext()!
without any parameters allocates a new JSVirtualMachine each time and when the context gets deinit'd (whenever a template changes) the JSVirtualMachine also deinit's. During that deinit it takes over the main thread and deadlocks sourcery file watchers.This change uses dedicated VMs for the entire duration of the Sourcery process. The downside is that memory usage may go up over time in watch mode, but it wont deadlock and subsequent parsing/executing of templates may speed up as it can utilise a byte code cache etc…