Skip to content

fix: reference missing files in schema (Closes #20752) #20761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zvdy
Copy link
Contributor

@zvdy zvdy commented May 14, 2025

Summary

Added the missing schemas to the map in order to fix #20752 , did not modify updateHashFile as the modified files are not binaries:

Testing

❯ go run ./update_cni_plugins_version.go
I0515 00:26:31.427559  559144 update.go:91] The Plan:
{
  ".github/workflows/master.yml": {
    "Content": null,
    "Replace": {
      "CNI_PLUGIN_VERSION=\\\"v[0-9.]+\\\"": "CNI_PLUGIN_VERSION=\\\"v9.9.9\\\""
    }
  },
  ".github/workflows/pr.yml": {
    "Content": null,
    "Replace": {
      "CNI_PLUGIN_VERSION=\\\"v[0-9.]+\\\"": "CNI_PLUGIN_VERSION=\\\"v9.9.9\\\""
    }
  },
  "deploy/iso/minikube-iso/arch/aarch64/package/cni-plugins-latest-aarch64/cni-plugins-latest.mk": {
    "Content": null,
    "Replace": {
      "CNI_PLUGINS_LATEST_AARCH64_VERSION = .*": "CNI_PLUGINS_LATEST_AARCH64_VERSION = v9.9.9"
    }
  },
  "deploy/iso/minikube-iso/arch/x86_64/package/cni-plugins-latest/cni-plugins-latest.mk": {
    "Content": null,
    "Replace": {
      "CNI_PLUGINS_LATEST_VERSION = .*": "CNI_PLUGINS_LATEST_VERSION = v9.9.9"
    }
  },
  "deploy/kicbase/Dockerfile": {
    "Content": null,
    "Replace": {
      "CNI_PLUGINS_LATEST_VERSION=.*": "CNI_PLUGINS_LATEST_VERSION=\"v9.9.9\""
    }
  },
  "hack/jenkins/installers/check_install_cni_plugins.sh": {
    "Content": null,
    "Replace": {
      "CNI_PLUGIN_VERSION=\\\"v[0-9.]+\\\"": "CNI_PLUGIN_VERSION=\\\"v9.9.9\\\""
    }
  }
}
I0515 00:26:31.428074  559144 update.go:99] Local repo successfully updated

These would be the files (version is changed as i had to hardcode data in order to run it locally )

❯ rg --hidden 'CNI_PLUGIN_VERSION' --glob '!*.md'
.github/workflows/master.yml
570:          CNI_PLUGIN_VERSION=\"v9.9.9\"
571:          CNI_PLUGIN_TAR="cni-plugins-linux-amd64-$CNI_PLUGIN_VERSION.tgz" # change arch if not on amd64
574:          curl -LO "https://github.com/containernetworking/plugins/releases/download/$CNI_PLUGIN_VERSION/$CNI_PLUGIN_TAR"

.github/workflows/pr.yml
568:          CNI_PLUGIN_VERSION=\"v9.9.9\"
569:          CNI_PLUGIN_TAR="cni-plugins-linux-amd64-$CNI_PLUGIN_VERSION.tgz" # change arch if not on amd64
572:          curl -LO "https://github.com/containernetworking/plugins/releases/download/$CNI_PLUGIN_VERSION/$CNI_PLUGIN_TAR"

hack/jenkins/installers/check_install_cni_plugins.sh
19:CNI_PLUGIN_VERSION=\"v9.9.9\"
20:CNI_PLUGIN_TAR="cni-plugins-linux-amd64-$CNI_PLUGIN_VERSION.tgz"
23:curl -qL -O "https://github.com/containernetworking/plugins/releases/download/$CNI_PLUGIN_VERSION/$CNI_PLUGIN_TAR"

cc: @medyagh

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 14, 2025
Copy link

linux-foundation-easycla bot commented May 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha May 14, 2025 22:33
@k8s-ci-robot
Copy link
Contributor

Welcome @zvdy!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @zvdy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 14, 2025
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@zvdy
Copy link
Contributor Author

zvdy commented May 14, 2025

Sorry for the duped commits, I lost the thread while going through the CLA

@medyagh
Copy link
Member

medyagh commented May 14, 2025

excellent ! thank you @zvdy for the quick fix

@medyagh
Copy link
Member

medyagh commented May 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, zvdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@medyagh medyagh merged commit 4fd7502 into kubernetes:master May 14, 2025
18 of 19 checks passed
@zvdy zvdy deleted the fix-issue-20752-update-cni-plugins-version branch May 15, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve automation "update-cni-plugins-version" to update it everywhere
4 participants