-
Notifications
You must be signed in to change notification settings - Fork 5k
fix: reference missing files in schema (Closes #20752) #20761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reference missing files in schema (Closes #20752) #20761
Conversation
Welcome @zvdy! |
Hi @zvdy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…github.com/zvdy/minikube into fix-issue-20752-update-cni-plugins-version
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request. You can edit the title by writing /retitle in a comment.
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
|
excellent ! thank you @zvdy for the quick fix |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, zvdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Added the missing schemas to the map in order to fix #20752 , did not modify
updateHashFile
as the modified files are not binaries:Testing
These would be the files (version is changed as i had to hardcode
data
in order to run it locally )