Conversation
… TaskGroupEnvironment - Add WorkspaceRegistry (SQLite-backed) for tracking workspaces and files across trials - UUID-based workspace directory naming for uniqueness and persistence - Global FSManager scope (base_work_dir) enabling cross-trial file access for interventions - Registry-backed path resolution replacing fragile rglob search - File tracking on FSManager writes via registry - Consolidate duplicate TaskGroupEnvironment classes: ML and samplemath now use core class - Core TaskGroupEnvironment supports hidden_args_keys, fsmanager_app, extra_file_tools, extra_fsmanager_tool_classes - corral_md subclasses core, overriding only prompt and score - Add workspace_id to schema, server, router, and report plumbing - Add CLAUDE.md for repository guidance
…in scoring Remove smart_resolve_path/rglob from the scoring hot path. Tools now return absolute paths (WriteFileTool, CopyFileTool) and score() resolves relative paths deterministically against the trial workspace directory. Eliminates fragile regex parsing, registry lookup, and filesystem search.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
|
Is this not needed for the webpage as well? Or for what is this PR? |
2 participants
Summary
smart_resolve_path,rglob, regex parsing) from the scoring hot path — replaced with deterministic resolution: relative paths are prepended with the trial workspace directory, absolute paths and JSON data pass through unchanged.base_work_dir, so relative paths from tools resolve correctly within each trial.resolve_pathfunctions removed from catalyst and ML score modules.resolve_working_dir_path(consolidate, select, filter, prepare, train tools).Files changed
src/corral/utils/task_group.pyscore(), FSManager scoped to trial workspacesrc/corral/utils/io_tools.pytasks/catalyst/src/catalyst/score.pysmart_resolve_path, deadresolve_pathtasks/ml/src/ml/score.pyresolve_pathtasks/ml/src/ml/tools.pytasks/resistor_network/src/resistor_network/score.pysmart_resolve_pathtasks/catalyst/tests/test_environment_integration.pytasks/ml/tests/test_unit.pyresolve_pathtestTest plan
cd tasks/catalyst && CORRAL_WORK_DIR=$(mktemp -d) uv run python -m pytest tests -v --rootdir=.cd tasks/ml && CORRAL_WORK_DIR=$(mktemp -d) uv run python -m pytest tests -v --rootdir=.cd tasks/resistor_network && CORRAL_WORK_DIR=$(mktemp -d) uv run python -m pytest tests -v --rootdir=.