Fix: create_new_library existence check uses pre-safe-name string (#1155)#1305
Open
shr8769 wants to merge 1 commit into
Open
Fix: create_new_library existence check uses pre-safe-name string (#1155)#1305shr8769 wants to merge 1 commit into
shr8769 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1155.
create_new_library() ran the database-level safe_name() conversion
(which rewrites characters like '-' to '_' on sqlite/postgres) after
check_if_library_exists(). Calling create_new_library with the same
original name a second time checked existence under the un-rewritten
name, found nothing, and attempted to recreate the library — colliding
with the already-registered remapped name and raising an
IntegrityError.
This moves the safe_name conversion before the existence check, so
both operate on the same final name. Added a regression test
(test_create_new_library_idempotent_with_unsafe_name) that reproduces
the original failure on sqlite and confirms the fix.
Verified locally:
unsafe name raised sqlite3.IntegrityError.