Fix Symbol Visibility#72
Open
StDymphna wants to merge 2 commits into
Open
Conversation
…with LTO/-fvisibility=hidden
hishamhm
reviewed
Feb 1, 2026
|
|
||
| #undef LUAMOD_API | ||
| #define LUAMOD_API extern | ||
| #define LUAMOD_API __attribute__((visibility("default"))) extern |
Member
There was a problem hiding this comment.
This probably needs to be wrapped with if defined(__GNUC__) like the other cases below.
Contributor
|
Status? Should this be rebased? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly marks API symbols with attribute((visibility("default")) on GNU compatible compilers. When building with -fvisibility=hidden, LTO, etc., each lib had its symbol hidden.
This ensures the shared libraries will respectively export luaopen_compat53_io, luaopen_compat53_string, luaopen_compat53_table, and luaopen_compat53_utf8.