Skip to content

Fix race, update API and container image #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 28, 2021
Merged

Fix race, update API and container image #47

merged 7 commits into from
Apr 28, 2021

Conversation

r10r
Copy link
Contributor

@r10r r10r commented Apr 28, 2021

  • Fix race in lxcri start
  • Make go-lxc config item wrapper functions private
  • Upgrade container image

r10r added 7 commits April 27, 2021 20:18
@r10r
Update godoc.
c474404 
Signed-off-by: Ruben Jenster <[email protected]>
@r10r
Cleanup cli doc.
a4dfea1 
Remove environment variables from cli doc.
The output of lxcri --help is preferable and is always up-to-date.

Signed-off-by: Ruben Jenster <[email protected]>
@r10r
Make lxc *ConfigItem wrapper functions private.
15293bf 
Don't encourage API users to mix the lxcri and go-lxc API.
The user should only use the OCI specs.Spec to create the container if
possible. The go-lxc Container is exported as Container.LinuxContainer
and can be used to access the go-lxc API if there is really a need for it.

Signed-off-by: Ruben Jenster <[email protected]>
@r10r
Fix race waiting for container startup.
c0071b1 
It's not an error if the lxc monitor process exits,
while waiting for container startup.
It simply indicates that either the container process
failed to execute in first place or is a short-lived process that
has already returned.

Signed-off-by: Ruben Jenster <[email protected]>
@r10r
install: Complete archlinux support.
4a69f6c 
Signed-off-by: Ruben Jenster <[email protected]>
@r10r
Dockerfile: Upgrade package versions.
f5fd39a 
* golang 1.16.2 -> 1.16.3
* cri-o: 1.20 -> 1.20.2
* kubernetes server binaries: 1.20.4 -> 1.20.6

Signed-off-by: Ruben Jenster <[email protected]>
@r10r
Dockerfile: Pin a recent liblxc version.
eee7558 
Signed-off-by: Ruben Jenster <[email protected]>
@r10r
Copy link
Contributor Author

r10r commented Apr 28, 2021 •
edited
Loading

Hi @stgraber I need your help on the pull request checks. The 'Branch target' and 'DCO' checks are always stuck.
I know what the DCO check does - but what is the 'Branch target' check all about?

@r10r r10r merged commit d05cd0c into lxc:main Apr 28, 2021
@stgraber
Copy link
Member

The tests are currently waiting as we need to restart jenkins for a security update, they'll be scheduled right after that.
The DCO check confirms all commits have the Signed-off-by string, the branch target check validates that code is targeted at the main branch.

@r10r
Copy link
Contributor Author

r10r commented Apr 28, 2021

The tests are currently waiting as we need to restart jenkins for a security update, they'll be scheduled right after that.

Thanks for the info! I was too fast with merging. Next time I'll wait for the checks to complete.

@r10r
Copy link
Contributor Author

r10r commented Apr 28, 2021

Can we implemented these checks through github actions in the long run ?

@stgraber
Copy link
Member

Github would need to improve for that. There isn't a way currently to add Github Actions to all projects within an organization without having to manually commit them to every repos.

@r10r
Copy link
Contributor Author

r10r commented Apr 28, 2021

Ok, I see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r10r @stgraber