-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: replace invalid --env-file with dotenv-cli for tsup onSuccess #7443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: preview
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/live/package.json
(2 hunks)
🔇 Additional comments (1)
apps/live/package.json (1)
59-60
: dotenv-cli stays in devDependenciesThe production
start
script uses Node’s native--env-file
flag (not thedotenv
binary), so only thedev
script actually invokesdotenv-cli
. Keeping it underdevDependencies
is correct.• File: apps/live/package.json
•dev
script:tsup --watch --onSuccess "dotenv -e .env -- node dist/server.js"
•start
script:node --env-file=.env dist/server.js
No changes needed.
…-cli to dependencies
We are looking into implementing other alternatives like dotenvx than sticking to dotenv. Feel free to make those changes. |
Description
Replaced
--env-file
flag (unsupported by Node.js) in thedev
script of thelive
package withdotenv-cli
. This prevents theCACError
when starting the development server withyarn dev
.Type of Change
Screenshots and Media (if applicable)
No visual changes.
Test Scenarios
yarn dev
inside thepackages/live
directory..env
.References
None
Summary by CodeRabbit