-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: Replace unclear blue dot indicators with semantic badges in filter UI #7524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: preview
Are you sure you want to change the base?
Conversation
WalkthroughThis change updates the visual indicators for filter states across several UI components. Small colored dots previously used to indicate active filters have been replaced with larger, styled badges featuring centered SVG icons or, in one case, a "LIVE" pill label. No logic or control flow was altered. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI_Component
participant Filter_Indicator
User->>UI_Component: Interacts with filter button
UI_Component->>Filter_Indicator: Determine filter state
alt Filter applied
Filter_Indicator->>UI_Component: Render badge with SVG icon or "LIVE" label
else No filter applied
Filter_Indicator->>UI_Component: Render no indicator
end
UI_Component->>User: Display updated filter indicator
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related issues
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings
apps/web/core/components/issues/issue-detail-widgets/sub-issues/filters.tsx (1)Learnt from: mathalav55 apps/web/core/components/issues/issue-detail-widgets/sub-issues/display-filters.tsx (1)Learnt from: mathalav55 apps/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1)Learnt from: mathalav55 🔇 Additional comments (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Fixed unclear semantics of blue dot indicators in issue filter UI by replacing them with semantic visual indicators:
#7448
Type of Change
References
Files Changed
apps/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx
apps/web/core/components/issues/issue-layouts/filters/header/helpers/filter-option.tsx
apps/web/core/components/issues/issue-detail/issue-activity/activity-filter.tsx
apps/web/core/components/issues/issue-detail-widgets/sub-issues/filters.tsx
apps/web/core/components/issues/issue-detail-widgets/sub-issues/display-filters.tsx
Summary by CodeRabbit