ci: add autofix.ci#20
Merged
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds an
autofix.ciworkflow that automatically pushes lint/format fixes onto pull requests. When a contributor opens or updates a PR, the workflow runs the repo's mutating fixer (pnpm run lint, i.e.biome check --write) and, via the autofix.ci GitHub App, commits any resulting fixes straight back onto the PR branch. Contributors never see a red formatting/lint check they have to reproduce and fix by hand.The autofix.ci GitHub App is installed org-wide for marimo-team (confirmed by an org admin), so this works as soon as it merges — no per-repo setup required.
How it composes with the existing lint gate
CI's
biome ci .lint step stays exactly as-is: it's non-mutating and still fails the build on anything that can't be auto-fixed (genuine lint errors are meant to be surfaced, not silently rewritten). autofix.ci is the complement — it handles the mechanical fixes (formatting, safe lint autofixes) so that class of failure disappears from the contributor's plate. The fixer step is guarded with|| trueso unfixable lint errors don't block uploading the fixes that did apply; CI remains the source of truth for reporting them.The setup steps (checkout / pnpm / Node) mirror
test.ymlexactly, with the same SHA-pinned action versions.Verification
pnpm install --ignore-scripts --frozen-lockfile, ranpnpm run lint→ no diff (tree stays clean; only pre-existing non-fixable warnings, which CI already reports).actionlint.nameis exactlyautofix.ci(required — the service identifies the workflow by name for security) and theautofix-ci/actionstep runs last.Part of the marimo-team engineering-excellence initiative.