docs: define vNext language-service contracts#171
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
Light2Dark
marked this pull request as ready for review
July 24, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines the accepted vNext capability charter and ADR 0001 before runtime implementation. The decision establishes a shared framework-independent language service, one disposable session per document, atomic revision-guarded updates, original-document UTF-16 ranges, explicit request outcomes, scoped catalog epochs, provider source forms, and a thin CodeMirror lifecycle adapter.\n\nThe contracts were derived from the repository research and current marimo integration, then iterated through three fresh-context design reviews and two blocker-resolution loops. Local lint, typecheck, test integrity, workflow validation, diff checks, and aggregate coverage pass.
Summary by cubic
Adds ADR 0001 and a capability charter defining the vNext SQL language-service contracts. Establishes a framework-agnostic service with per-document sessions, atomic revision-guarded updates, original-document UTF-16 ranges, unified request outcomes, and a thin
CodeMirroradapter ahead of runtime work.SqlLanguageServiceand per-documentSqlDocumentSessionwith atomic text/context updates.CodeMirroradapter; walking-skeleton scope (relation completion first).Written for commit 66853b3. Summary will update on new commits.