fix(ci): download artifact before pnpm setup in publish job#15
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the publish job in the release workflow by ensuring the package artifact (which contains package.json and its packageManager field) is downloaded before pnpm/action-setup runs, and it also corrects a YAML indentation issue so steps are properly structured.
Changes:
- Reordered the
publishjob steps soactions/download-artifactruns beforepnpm/action-setup. - Fixed the mis-indentation of the
Setup Node.jsstep in thepublishjob.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The publish job has no checkout step, so package.json (with the packageManager field) only exists after the artifact download. Running pnpm/action-setup first leaves it with no pnpm version to read.
mscolnick
force-pushed
the
fix/release-pnpm-setup-order
branch
from
June 8, 2026 15:29
c90d510 to
5c0db27
Compare
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publishjob has nocheckoutstep, sopackage.json(withpackageManager) only exists after the artifact download. Runningpnpm/action-setupfirst leaves it with no pnpm version to read — the same failure mode that broke codemirror-sql's release once it moved to action-setup v6 (v4 still has a fallback, so this is latent here).Fix: reorder so the artifact download runs before pnpm setup.
Also fixes a pre-existing mis-indented
Setup Node.jsstep.