feat(connections): searchable combobox for secret/env fields by Light2Dark · Pull Request #10253 · marimo-team/marimo

Light2Dark · 2026-07-21T09:49:14Z

📝 Summary

Reworks the secret/env picker used across database and storage connection forms.

Replaces the read-only Input + key dropdown with a searchable combobox (SecretCombobox) so users can quickly filter secrets by name, especially when many env vars are present.
For non-secret fields, users can still commit a free-text literal ("Use ...") or search secrets; password/token fields are secrets-only.
The "create secret" flow pre-fills the modal with the typed value, reducing re-typing.
Tightens each field's optionRegex from broad .*x.* matchers to targeted patterns, so Recommended env vars are actually relevant and noise (e.g. KUBERNETES_SERVICE_HOST for a Host field) is excluded.
Extracts partitionSecretKeys as a pure, tested helper.

Screen.Recording.2026-07-22.at.12.57.43.AM.mov

Why: the previous dropdown was hard to use with long secret lists, and the loose regexes surfaced unrelated env vars as recommendations, undermining trust in the suggestions.

📋 Pre-Review Checklist

For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

I have read the contributor guidelines.
Documentation has been updated where applicable, including docstrings for API changes.
Tests have been added for the changes made.

Made with Cursor

Replace the input + dropdown key picker with a searchable combobox that lets users filter secrets, commit free-text literals (non-secret fields), or create a new secret pre-filled with the typed value. Co-authored-by: Cursor <cursoragent@cursor.com>

Replace broad `.*x.*` matchers with targeted patterns per field so the combobox recommends relevant env vars (and excludes noise like KUBERNETES_SERVICE_HOST). Add tests for the partitioning logic. Co-authored-by: Cursor <cursoragent@cursor.com>

vercel · 2026-07-21T09:49:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
marimo-docs	Ready	Preview, Comment	Jul 21, 2026 3:54pm

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Light2Dark · 2026-07-21T09:54:42Z

@cubic-dev-ai please review

cubic-dev-ai · 2026-07-21T09:54:50Z

@cubic-dev-ai please review

@Light2Dark I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 6 files

Architecture diagram

sequenceDiagram
    participant User
    participant Form as Connection Form
    participant Renderer as ENV_RENDERER
    participant Combobox as SecretCombobox
    participant Partitioner as partitionSecretKeys
    participant SecretsCtx as SecretsContext
    participant Modal as WriteSecretModal

    Note over User,Modal: Connection field with optionRegex (e.g., Host, Password)

    User->>Form: Open connection form
    Form->>Renderer: Render field with optionRegex
    Renderer->>SecretsCtx: Read secretKeys, providerNames
    SecretsCtx-->>Renderer: secretKeys[], providerNames[]
    Renderer->>Partitioner: partitionSecretKeys(keys, optionRegex)
    Partitioner-->>Renderer: {recommended, other}
    Renderer->>Combobox: Render with value, onChange, secretsOnly, recommended, other, onCreateSecret

    alt Field is password/token (secretsOnly = true)
        Note over Combobox: Only secrets can be chosen, no free-text
    else Field is text (secretsOnly = false)
        Note over Combobox: User can select secret or type a literal
    end

    User->>Combobox: Click trigger
    Combobox->>Combobox: Open popover, show search input

    alt User types search text
        Combobox->>Combobox: Filter recommended/other keys and show "Use ..." option (if not secretsOnly)
    end

    alt User selects a secret key
        Combobox->>Combobox: prefixSecret(key)
        Combobox->>Renderer: onChange(prefixedKey)
        Renderer->>Form: Update field value
    else User commits custom free-text value
        Combobox->>Renderer: onChange(literalText)
        Renderer->>Form: Update field value
    else User clicks "Create a new secret"
        Combobox->>Modal: Open with initialValue = search text
        Modal->>User: Fill key/value/location
        User->>Modal: Confirm
        Modal->>SecretsCtx: refreshSecrets()
        SecretsCtx-->>Modal: new secret added
        Modal->>Combobox: onSuccess(secretKey)
        Combobox->>Combobox: prefixSecret(secretKey)
        Combobox->>Renderer: onChange(prefixedKey)
        Renderer->>Form: Update field value
    end

    Note over Renderer,Partitioner: NEW: stricter optionRegex improves recommended matches

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

- Bound the `pat` token matcher to separators so PATH-like vars aren't recommended - Allow non-secret fields to commit a literal even when it matches a secret key - Remove the unreachable CommandEmpty block (Create item always matches) Co-authored-by: Cursor <cursoragent@cursor.com>

Add a clear control on the trigger so optional fields can be reset, and keep the create-secret menu label generic so typed secrets aren't echoed. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

cubic-dev-ai

All reported issues were addressed across 1 file (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Move clear to a sibling button (avoid nested controls) and add a Clear item in the menu for keyboard users. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

kirangadhave · 2026-07-21T22:21:57Z

+ * - Default: pick a secret, create one, or commit a free-text literal.
+ * - `secretsOnly`: pick or create a secret only (for passwords/tokens/keys).
+ */
+export const SecretCombobox: React.FC<SecretComboboxProps> = ({


We have a headless useSelectList hook for building components like this. Maybe you can also use the SelectList component directly.

marimo/frontend/src/components/ui/select-core/use-select-list.ts

Line 273 in c55f69b

export function useSelectList<V>({

I tried, and it made some parts cleaner and some parts more unreadable (to adapt to the hook). I think it's fine to keep this for now, since it's quite custom. But happy to refactor in the future.

Interesting what did it make harder? I would like to see if i can improve the hook

#10267 first draft

github-actions · 2026-07-22T18:20:13Z

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.15-dev58

Light2Dark and others added 2 commits July 21, 2026 17:48

Light2Dark requested a review from Copilot July 21, 2026 09:49

Copilot AI reviewed Jul 21, 2026

Light2Dark added the enhancement New feature or request label Jul 21, 2026

vercel Bot deployed to Preview July 21, 2026 09:49 View deployment

github-actions Bot added the team-draft label Jul 21, 2026

Light2Dark requested a review from Copilot July 21, 2026 09:51

Copilot AI reviewed Jul 21, 2026

cubic-dev-ai Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread frontend/src/components/editor/connections/secret-combobox.tsx Outdated

Comment thread frontend/src/components/editor/connections/database/schemas.ts Outdated

Comment thread frontend/src/components/editor/connections/secret-combobox.tsx Outdated

vercel Bot deployed to Preview July 21, 2026 14:45 View deployment

fix(connections): clear secret combobox value and fix create copy

db6d427

Add a clear control on the trigger so optional fields can be reset, and keep the create-secret menu label generic so typed secrets aren't echoed. Co-authored-by: Cursor <cursoragent@cursor.com>

Light2Dark marked this pull request as ready for review July 21, 2026 14:56

vercel Bot deployed to Preview July 21, 2026 14:56 View deployment

Light2Dark requested a review from Copilot July 21, 2026 15:00

Copilot started reviewing on behalf of Light2Dark July 21, 2026 15:00 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread frontend/src/components/editor/connections/secret-combobox.tsx Outdated

cubic-dev-ai Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread frontend/src/components/editor/connections/secret-combobox.tsx Outdated

fix(connections): make secret combobox clear keyboard-accessible

649a4e8

Move clear to a sibling button (avoid nested controls) and add a Clear item in the menu for keyboard users. Co-authored-by: Cursor <cursoragent@cursor.com>

Light2Dark requested a review from Copilot July 21, 2026 15:38

Copilot started reviewing on behalf of Light2Dark July 21, 2026 15:38 View session

vercel Bot deployed to Preview July 21, 2026 15:39 View deployment

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread frontend/src/components/editor/connections/secret-combobox.tsx

remove clear

22e352d

vercel Bot deployed to Preview July 21, 2026 15:54 View deployment

Light2Dark requested a review from mscolnick July 21, 2026 16:58

Light2Dark removed the team-draft label Jul 21, 2026

kirangadhave reviewed Jul 21, 2026

View reviewed changes

kirangadhave approved these changes Jul 22, 2026

View reviewed changes

mscolnick merged commit 2a206af into main Jul 22, 2026
35 checks passed

mscolnick deleted the feat/secret-combobox branch July 22, 2026 18:13

Uh oh!

Conversation

Light2Dark commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

📋 Pre-Review Checklist

✅ Merge Checklist

Uh oh!

vercel Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Light2Dark commented Jul 21, 2026

Uh oh!

cubic-dev-ai Bot commented Jul 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

kirangadhave Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Light2Dark Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirangadhave Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

Light2Dark Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Light2Dark commented Jul 21, 2026 •

edited

Loading

vercel Bot commented Jul 21, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

Light2Dark Jul 22, 2026 •

edited

Loading

Light2Dark Jul 22, 2026 •

edited

Loading