Make control loop test deterministic#10280
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the “control loop doesn’t block the event loop” test deterministic by replacing a time-based starvation test with a direct assertion that the blocking queue.get() runs on a non-event-loop thread.
Changes:
- Added a deterministic unit test that verifies
threaded_queue_reader()offloadsQueue.get()to a worker thread. - Removed a time-based polling/starvation test that relied on real time and could be flaky across environments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/_runtime/test_kernel_lifecycle.py | Adds a deterministic test validating threaded_queue_reader() runs queue.get() off the event-loop thread. |
| tests/_runtime/test_control_loop.py | Removes a time-based starvation test (likely flaky) in favor of the deterministic approach. |
Replace the timing-based synthetic test with a deterministic assertion that the production queue reader offloads blocking work from the event-loop thread. Closes MO-6895
akshayka
approved these changes
Jul 23, 2026
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.15-dev71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the timing-based synthetic test with a deterministic assertion that the production queue reader offloads blocking work from the event-loop thread.
Closes MO-6895